docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

APP-179 Simplify templating of docker app #602

Closed aiordache closed 5 years ago

aiordache commented 5 years ago

Signed-off-by: Anca Iordache anca.iordache@docker.com - What I did Implemented the parameters substitution using simple string replace instead of the compose loader.

- How I did it Steps:

- How to verify it Internal refactoring, shouldn't change functionality for end-users.

- Description for the changelog Simplifed docker app templating - parameter substitution done with string replace

- A picture of a cute animal (not mandatory but encouraged)

image

codecov[bot] commented 5 years ago

Codecov Report

Merging #602 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #602   +/-   ##
=======================================
  Coverage   74.58%   74.58%           
=======================================
  Files          53       53           
  Lines        2998     2998           
=======================================
  Hits         2236     2236           
  Misses        490      490           
  Partials      272      272

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update daee953...98434e6. Read the comment docs.

silvin-lubecki commented 5 years ago

@ulyssessouza PTAL