search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Configure GOPROXY #606

Closed ndeloof closed 5 years ago

ndeloof commented 5 years ago

- What I did introduce support for GOPROXY

- How I did it pass --build-arg according to local value. set GOPROXY to direct for CI

- How to verify it No obvious way

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

codecov[bot] commented 5 years ago

Codecov Report

Merging #606 into master will decrease coverage by 0.28%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #606      +/-   ##
=========================================
- Coverage   72.69%   72.4%   -0.29%     
=========================================
  Files          54      54              
  Lines        2809    2765      -44     
=========================================
- Hits         2042    2002      -40     
+ Misses        508     506       -2     
+ Partials      259     257       -2
Impacted Files Coverage Δ
render/render.go 76.38% <0%> (-5.51%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 964210e...5234af7. Read the comment docs.

ndeloof commented 5 years ago

@thaJeztah great suggestion, I didn't know about the --build-arg=FOO trick, you made my day ;)

thaJeztah commented 5 years ago

Works the same for --env btw, and it's a great way to optionally pass an env-var to a container 😅