search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.58k stars 177 forks source link

Remove 3rd party software integrations #614

Closed jcsirot closed 4 years ago

jcsirot commented 4 years ago

- What I did 3rd party software integrations have been written during the project early stage and is now obsolete and not maintained. It has to be removed from the codebase.

- How I did it Remove the integrations directory and the related build steps in the Makefiles

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

ob_3cfd99_maxresdefault-1

silvin-lubecki commented 4 years ago

https://github.com/docker/app/blob/master/Jenkinsfile#L161 There too

jcsirot commented 4 years ago

@silvin-lubecki Indeed, I've seen it too late. PR updated

codecov[bot] commented 4 years ago

Codecov Report

Merging #614 into master will decrease coverage by 0.37%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
- Coverage   72.73%   72.35%   -0.38%     
==========================================
  Files          50       50              
  Lines        2648     2583      -65     
==========================================
- Hits         1926     1869      -57     
+ Misses        486      483       -3     
+ Partials      236      231       -5
Impacted Files Coverage Δ
internal/packager/init.go 60.97% <0%> (-8.18%) :arrow_down:
types/parameters/parameters.go 93.65% <0%> (-3.18%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9eb813...78a90f0. Read the comment docs.