search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.58k stars 177 forks source link

Jenkinsfile: use --password-stdin #624

Closed thaJeztah closed 4 years ago

thaJeztah commented 4 years ago

before:

docker login -u $REGISTRY_USERNAME -p $REGISTRY_PASSWORD
WARNING! Using --password via the CLI is insecure. Use --password-stdin.
Login Succeeded

with this PR:

echo $REGISTRY_PASSWORD | docker login -u "$REGISTRY_USERNAME" --password-stdin
Login Succeeded

- How to verify it

Ehm, don't know; I don't think the Jenkinsfile change will run on this PR (because I'm not an owner in this repo)

- A picture of a cute animal (not mandatory but encouraged)

monkey_phone

thaJeztah commented 4 years ago

@ndeloof 🤗

thaJeztah commented 4 years ago

Hm... interesting; https://ci.docker.com/teams-dsg/blue/rest/organizations/jenkins/pipelines/dsg/pipelines/app/branches/PR-624/runs/1/nodes/14/log/?start=0


+ FOSSA_API_KEY=**** BRANCH_NAME=PR-624 make fossa-analyze
docker run -i --rm -e FOSSA_API_KEY \
    -e GO111MODULE=on \
    -v /home/ubuntu/workspace/dsg_app_PR-624/src/github.com/docker/app/:/go/src/github.com/docker/app \
    -w /go/src/github.com/docker/app \
    dockereng/fossa-analyzer analyze --option all-tags:true --option allow-unresolved:true --branch PR-624
WARNING Could not determine whether module is built: could not run go list:  (exit status 1)
WARNING Module does not appear to be built
FATAL Could not analyze: could not run go list:  (exit status 1)
Makefile:115: recipe for target 'fossa-analyze' failed
make: *** [fossa-analyze] Error 1
script returned exit code 2

error is mentioned in https://github.com/fossas/fossa-cli/issues/496 (and a fix in https://github.com/fossas/fossa-cli/pull/439)

/cc @zelahi

codecov[bot] commented 4 years ago

Codecov Report

Merging #624 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #624   +/-   ##
=======================================
  Coverage   71.95%   71.95%           
=======================================
  Files          49       49           
  Lines        2560     2560           
=======================================
  Hits         1842     1842           
  Misses        486      486           
  Partials      232      232

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 24b127c...59ec475. Read the comment docs.

thaJeztah commented 4 years ago

all green now

zelahi commented 4 years ago

Yup, I re-triggered it. Tho I didn't do anything on the fossa side so I'm curious how it happened

silvin-lubecki commented 4 years ago

Thank you @thaJeztah ❤️