aiordache commented 5 years ago

Signed-off-by: Anca Iordache anca.iordache@docker.com

Requires PR-2095

- What I did Enabled validate command only for experimental mode

- How I did it Added validate command to the list of commands only if experimental flag is on. - How to verify it

$ DOCKER_CLI_EXPERIMENTAL="disabled" docker app --help
Usage:  docker app COMMAND
Commands:
  ...
  run         Run an App from an App image
  update      Update a running App

$ DOCKER_CLI_EXPERIMENTAL="enabled" docker app --help
Usage:  docker app COMMAND
Commands:
  ...
  run         Run an App from an App image
  update      Update a running App
  validate    Check that an App definition (.dockerapp) is syntactically correct

$ DOCKER_CLI_EXPERIMENTAL="enabled" docker app validate
Validated "/home/anca/go/src/github.com/docker/app/examples/test.dockerapp"

$ DOCKER_CLI_EXPERIMENTAL="disabled" docker app validate
"validate" is not a docker app command
See 'docker app --help'

- Description for the changelog Add validate to the list of docker app commands only in experimental mode.

- A picture of a cute animal (not mandatory but encouraged) 8d1

thaJeztah commented 5 years ago

looks like there's a merge-conflict, so might need a rebase.

silvin-lubecki commented 5 years ago

The tests are failing.

ndeloof commented 5 years ago

What's the status of this one ? Shall we better close ?

aiordache commented 5 years ago

I am not sure about this :(

I'll rebase the PR on cli and wait for it to be accepted and merged, we are waiting for some feedback from Sebastiaan on it. Then, probably we can update the vendor in the PR for docker app....?

On Thu, Oct 3, 2019 at 10:37 AM Nicolas De loof notifications@github.com wrote:

What's the status of this one ? Shall we better close ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/docker/app/pull/625?email_source=notifications&email_token=AAGFXL3NBHBKDNTVWNCGCULQMW4MLA5CNFSM4IYZWFQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAHTW2Y#issuecomment-537869163, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGFXL3FIWZKJCADMHV4VDTQMW4MLANCNFSM4IYZWFQA .

codecov[bot] commented 4 years ago

Codecov Report

Merging #625 into master will decrease coverage by 0.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
- Coverage    69.3%   69.28%   -0.02%     
==========================================
  Files          63       63              
  Lines        3388     3396       +8     
==========================================
+ Hits         2348     2353       +5     
- Misses        731      733       +2     
- Partials      309      310       +1

Impacted Files	Coverage Δ
internal/commands/validate.go	`75% <100%> (+0.8%)`	:arrow_up:
internal/commands/root.go	`74.69% <100%> (+2.33%)`	:arrow_up:
types/parameters/parameters.go	`92.06% <0%> (-4.77%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e0989c...ed930a8. Read the comment docs.

docker / app

[WIP] APP-214 Enable 'docker app validate' for experimental mode only #625

Codecov Report