Closed glours closed 4 years ago
I'm not a Makefile expert too 😅
I'm not a Makefile expert too sweat_smile
nobody is
:exclamation: No coverage uploaded for pull request base (
master@b118ccd
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #631 +/- ##
========================================
Coverage ? 72.4%
========================================
Files ? 49
Lines ? 2577
Branches ? 0
========================================
Hits ? 1866
Misses ? 477
Partials ? 234
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b118ccd...38b3c12. Read the comment docs.
Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:
$ git clone -b "suitable_error_4_unknown_command" git@github.com:glours/app.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354506960
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
As a potential contributor of Docker App I want to run
make
ormake all
on docker-app source code without having errors during the end-to-end tests phase- What I did Add a build of the invocation image if needed - How I did it Check if the image is already present & if not build it - How to verify it
make
commandmake
command- A picture of a cute animal (not mandatory but encouraged)