search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.58k stars 177 forks source link

[WIP] Build tag #632

Closed ndeloof closed 4 years ago

ndeloof commented 4 years ago

- What I did Fix build so we can use arbitrary branch name, and more specifically dependabot support with use of / in branch names.

- How I did it Replaced use of BUILD_TAG (=job_name-build_number) as a variable to set transient docker images tag

- How to verify it This is what CI is made for :)

- Description for the changelog Fix build script so we can use dependabot

- A picture of a cute animal (not mandatory but encouraged) image

ndeloof commented 4 years ago

After a closer look, I notice we have Jenkins setup to build branches+PRs and the PR build actually succeed (as BUILD_TAG is then app-PR-xyz) but we also have a concurrent branch build running, which results in commit status. So I updated Jenkins configuration to avoid this.