Closed ulyssessouza closed 4 years ago
@ndeloof I know we rely on the docker/cli master branch, but we need to move on this. Moreover there will be a docker/cli release soon, and we will bump the cli then before next docker/app release 👍
:exclamation: No coverage uploaded for pull request base (
master@856c60a
). Click here to learn what that means. The diff coverage is100%
.
@@ Coverage Diff @@
## master #634 +/- ##
=========================================
Coverage ? 71.95%
=========================================
Files ? 49
Lines ? 2560
Branches ? 0
=========================================
Hits ? 1842
Misses ? 486
Partials ? 232
Impacted Files | Coverage Δ | |
---|---|---|
render/render.go | 80.23% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 856c60a...54fa534. Read the comment docs.
Closes #495
- What I did Remove redundant envfile section on render
- How I did it By passing the option to remove it after resolving the envvars
- How to verify it Please refer to https://github.com/docker/app/issues/495#issue-424390040 for the steps to reproduce
- Description for the changelog Remove redundant envfile section on render
- A picture of a cute animal (not mandatory but encouraged)![little-baphomet](https://user-images.githubusercontent.com/373485/65516581-89a7e380-dee1-11e9-8d92-6760877877c5.jpg)