search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.58k stars 177 forks source link

Revert #626 bumping gojsonschema #638

Closed silvin-lubecki closed 4 years ago

silvin-lubecki commented 4 years ago

Dependencybot only bumped the gopkg.toml and not the vendored code. It does not compile in the docker/cli code, so I prefer reverting the bump right now and fix the docker/cli code, then bump both of them. - A picture of a cute animal (not mandatory but encouraged)

image

GordonTheTurtle commented 4 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "fix-gojsonschema-vendoring" git@github.com:silvin-lubecki/app.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

codecov[bot] commented 4 years ago

Codecov Report

Merging #638 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   72.14%   72.14%           
=======================================
  Files          49       49           
  Lines        2542     2542           
=======================================
  Hits         1834     1834           
  Misses        479      479           
  Partials      229      229

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0093585...ff61e50. Read the comment docs.