docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.58k stars 177 forks source link

New command to list application images #639

Closed rumpl closed 4 years ago

rumpl commented 4 years ago

For now we show the reference, name and version.

- What I did

Added a new management command image and a subcommand ls (or list)

- How I did it

Some of the code is from this branch made by Silvin, added some more unit and e2e tests.

- How to verify it

And you should see the application

- Description for the changelog New subcommand docker app image ls to list docker applications that are in the local bundle store.

- A picture of a cute animal (not mandatory but encouraged) image

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@695509b). Click here to learn what that means. The diff coverage is 78.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #639   +/-   ##
=========================================
  Coverage          ?   72.12%           
=========================================
  Files             ?       51           
  Lines             ?     2665           
  Branches          ?        0           
=========================================
  Hits              ?     1922           
  Misses            ?      502           
  Partials          ?      241
Impacted Files Coverage Δ
internal/commands/root.go 69.3% <100%> (ø)
internal/commands/image/command.go 100% <100%> (ø)
internal/store/bundle.go 68.81% <68.75%> (ø)
internal/commands/image/list.go 83.6% <83.6%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 695509b...aa2de75. Read the comment docs.

jcsirot commented 4 years ago

LGTM but I think we should wait for #635 to be merged and then rebase this PR.