search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Ignore unknown files on image ls #649

Closed rumpl closed 5 years ago

rumpl commented 5 years ago

When a user opens the bundles directory with Finder it will add the junk file .DS_Store, this makes docker app image ls fail. With this change we silently ignore unknown files in the bundle store.

- What I did

Removed the check for .json files

- How to verify it

Open the bundle store in Finder (or add a file in the bundle store) and execute docker app image ls.

- A picture of a cute animal (not mandatory but encouraged) image

rumpl commented 5 years ago

Should we have a test on this part?

I'll make one

codecov[bot] commented 5 years ago

Codecov Report

Merging #649 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #649   +/-   ##
=======================================
  Coverage   71.66%   71.66%           
=======================================
  Files          50       50           
  Lines        2573     2573           
=======================================
  Hits         1844     1844           
  Misses        493      493           
  Partials      236      236

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7ca5e50...ee595b0. Read the comment docs.