search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Add specific error message for image tag cmd #659

Closed eunomie closed 5 years ago

eunomie commented 5 years ago

- What I did

Improve the UX by displaying a better error message when trying to tag an image/tag that doesn't exist.

- How I did it

Wrap the bundleStore access to output a dedicated error message.

- How to verify it

docker app image tag image_that_doesnt_exist test

docker app image tag image_that_exists:not-a-tag test

codecov[bot] commented 5 years ago

Codecov Report

Merging #659 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
+ Coverage   71.73%   71.76%   +0.03%     
==========================================
  Files          52       52              
  Lines        2643     2646       +3     
==========================================
+ Hits         1896     1899       +3     
  Misses        502      502              
  Partials      245      245
Impacted Files Coverage Δ
internal/commands/image/tag.go 89.18% <100%> (+0.95%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 81e475c...4bd45eb. Read the comment docs.