[WIP] Move docker/cli vendoring back to 19.03 branch

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub

Apache License 2.0

1.57k stars 176 forks source link

[WIP] Move docker/cli vendoring back to 19.03 branch #669

Closed chris-crone closed 4 years ago

chris-crone commented 4 years ago

Signed-off-by: Christopher Crone christopher.crone@docker.com

- What I did As the YAML library bump is now in the 19.03 branch for the CLI, I've moved our vendoring back to use that.

- How I did it

Update Gopkg.toml
Run make vendor

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

ndeloof commented 4 years ago

undefined: loader.WithDiscardEnvFiles https://github.com/docker/cli/commit/821f5ecf53c87a1f391d97c358f08c8d344cda8c not yet in 19.03

chris-crone commented 4 years ago

undefined: loader.WithDiscardEnvFiles docker/cli@821f5ec not yet in 19.03

@thaJeztah are there plans to add that to 19.03?

thaJeztah commented 4 years ago

@thaJeztah are there plans to add that to 19.03?

Oh, good one; looks harmless to cherry-pick if, so if you or @ulyssessouza could open a cherry-pick into the 19.03 branch, then perhaps it could still make it

chris-crone commented 4 years ago

We can bump this later