Closed ndeloof closed 4 years ago
Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:
$ git clone -b "revert-670-fossa" git@github.com:docker/app.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
Merging #673 into master will increase coverage by
0.11%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #673 +/- ##
==========================================
+ Coverage 72.07% 72.19% +0.11%
==========================================
Files 52 52
Lines 2636 2636
==========================================
+ Hits 1900 1903 +3
+ Misses 492 490 -2
+ Partials 244 243 -1
Impacted Files | Coverage Δ | |
---|---|---|
types/parameters/parameters.go | 96.82% <0%> (+4.76%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6338683...aa563c0. Read the comment docs.
Reverts docker/app#670
Fossa CI build isn't reported to Github as Jenkins github multibranch plugin has commit status context hardcoded : https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubNotificationContext.java#L150
Impacted files detection within a PR is someway broken as https://ci.docker.com/teams-dsg/job/dsg/job/app-fossa/view/change-requests/job/PR-655/1/console states
Stage "License Scan" skipped due to when conditional
while https://github.com/docker/app/pull/655/files do update dependencies and vendoring