search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Better app install error reporting #675

Closed rumpl closed 5 years ago

rumpl commented 5 years ago

- What I did

Made the output of docker app install be uniform with the docker run command. Removed the --pull flag, we align with what the cli is doing: searching locally first, then pulling if not found. The user needs to explicitly pull an app image if they want to install the latest version.

- How I did it

Removed a bunch of code

- How to verify it

Run:

docker app install unknown

You should see the output :

Unable to find application image "docker.io/library/unknown" locally
Unable to find application "unknown": failed to resolve bundle manifest "docker.io/library/unknown:latest": pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed

- Description for the changelog docker app install no longer has the --pull flag, an application already present locally should be pulled explicitly to update it.

- A picture of a cute animal (not mandatory but encouraged) image

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@90d8144). Click here to learn what that means. The diff coverage is 63.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #675   +/-   ##
=========================================
  Coverage          ?   71.34%           
=========================================
  Files             ?       56           
  Lines             ?     2886           
  Branches          ?        0           
=========================================
  Hits              ?     2059           
  Misses            ?      563           
  Partials          ?      264
Impacted Files Coverage Δ
internal/store/bundle.go 73.56% <ø> (ø)
internal/commands/root.go 78.88% <ø> (ø)
internal/commands/upgrade.go 58.18% <0%> (ø)
internal/commands/render.go 80.64% <100%> (ø)
internal/commands/inspect.go 69.23% <100%> (ø)
internal/commands/push.go 45.22% <100%> (ø)
internal/commands/pull.go 69.23% <60%> (ø)
internal/commands/cnab.go 71.36% <60.86%> (ø)
internal/commands/install.go 65.71% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90d8144...459b24c. Read the comment docs.