search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Set build arg values in docker.Makefile #680

Closed zappy-shu closed 4 years ago

zappy-shu commented 4 years ago

- What I did

Sets the values of the --build-args passed through to docker build from vars.mk when using make with docker.Makefile. This will correctly set the TAG so that the binary versions are set as when using the standard Makefile directly.

- How I did it

Constructed BUILD_ARGS using variables from vars.mk

- How to verify it

Run make -f docker.Makefile cross and ensure that the app --version command of the resulting binaries print a version (e.g. v0.6.0-516-g6a9e04b5c5-dirty) rather than unknown

- Description for the changelog

Sets build args when building with docker.Makefile

codecov[bot] commented 4 years ago

Codecov Report

Merging #680 into master will increase coverage by 0.03%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
+ Coverage   71.34%   71.37%   +0.03%     
==========================================
  Files          56       56              
  Lines        2886     2886              
==========================================
+ Hits         2059     2060       +1     
+ Misses        563      562       -1     
  Partials      264      264
Impacted Files Coverage Δ
types/parameters/parameters.go 93.65% <0%> (+1.58%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6a9e04b...a4c63e5. Read the comment docs.