Closed ndeloof closed 4 years ago
Could you rename internal/commands/install.go
to run.go
?
Merging #681 into master will decrease coverage by
0.5%
. The diff coverage is74.69%
.
@@ Coverage Diff @@
## master #681 +/- ##
==========================================
- Coverage 72.29% 71.78% -0.51%
==========================================
Files 58 56 -2
Lines 3140 2889 -251
==========================================
- Hits 2270 2074 -196
+ Misses 581 551 -30
+ Partials 289 264 -25
Impacted Files | Coverage Δ | |
---|---|---|
internal/commands/image/list.go | 81.81% <100%> (ø) |
:arrow_up: |
internal/commands/build/build.go | 61.66% <100%> (-4.39%) |
:arrow_down: |
internal/commands/image/tag.go | 89.18% <100%> (-0.56%) |
:arrow_down: |
internal/commands/inspect.go | 69.23% <100%> (ø) |
:arrow_up: |
internal/packager/bundle.go | 64% <33.33%> (-3.25%) |
:arrow_down: |
internal/store/bundle.go | 68.62% <64.7%> (-5.48%) |
:arrow_down: |
internal/commands/image/rm.go | 61.29% <66.66%> (-2.35%) |
:arrow_down: |
internal/commands/cnab.go | 71.36% <66.66%> (-4.51%) |
:arrow_down: |
internal/store/digest.go | 83.33% <83.33%> (ø) |
:arrow_up: |
... and 6 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 58e773c...f0cd91c. Read the comment docs.
- What I did Renamed
install/deploy
command to "run" to align withdocker run
UX- How I did it refactor > rename
- How to verify it docker app --help docker app run myapp
- Description for the changelog
deploy
command has been renamedrun
to align withdocker run
UX- A picture of a cute animal (not mandatory but encouraged)