Closed zappy-shu closed 4 years ago
:exclamation: No coverage uploaded for pull request base (
master@a4645a5
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #683 +/- ##
=========================================
Coverage ? 71.78%
=========================================
Files ? 56
Lines ? 2889
Branches ? 0
=========================================
Hits ? 2074
Misses ? 551
Partials ? 264
Impacted Files | Coverage Δ | |
---|---|---|
internal/names.go | 100% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a4645a5...68e3811. Read the comment docs.
- What I did
Added 2 labels to the containers when they are deployed by docker app:
These have been added so that Docker Desktop can differentiate between docker app deployments vs docker stack services.
- How I did it
Added the labels to the services in the invocation image
install
command (bothinstall
andupgrade
indocker app
) before callingRunDeploy
on the orchestrator.- How to verify it
Assertions for the labels have been added to the e2e tests. To verify manually:
docker app install
and theninspect
the running containers. They should have the labels as described above.docker app upgrade
on the installed app and theninspect
the running containers. They should have the labels as described above.- Description for the changelog
Added com.docker.app.namespace and com.docker.app.version labels to containers created by docker app.
- A picture of a cute animal (not mandatory but encouraged)