docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 176 forks source link

added app labels to container metadata #683

Closed zappy-shu closed 4 years ago

zappy-shu commented 4 years ago

- What I did

Added 2 labels to the containers when they are deployed by docker app:

These have been added so that Docker Desktop can differentiate between docker app deployments vs docker stack services.

- How I did it

Added the labels to the services in the invocation image install command (both install and upgrade in docker app) before calling RunDeploy on the orchestrator.

- How to verify it

Assertions for the labels have been added to the e2e tests. To verify manually:

- Description for the changelog

Added com.docker.app.namespace and com.docker.app.version labels to containers created by docker app.

- A picture of a cute animal (not mandatory but encouraged)

_108799047_harry-walker_oh-my_00000657

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a4645a5). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #683   +/-   ##
=========================================
  Coverage          ?   71.78%           
=========================================
  Files             ?       56           
  Lines             ?     2889           
  Branches          ?        0           
=========================================
  Hits              ?     2074           
  Misses            ?      551           
  Partials          ?      264
Impacted Files Coverage Δ
internal/names.go 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4645a5...68e3811. Read the comment docs.