search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

add a message in install cmd when trying to pull from registry #687

Closed glours closed 4 years ago

glours commented 4 years ago

- What I did Add a message saying we're pulling from the registry when an app isn't find in the local bundle store

- How I did it Print the message in the standard output of the CLI

- How to verify it try to pull an unknown image & check the output is like that 

> docker app install unknown
Unable to find application image "unknown:latest" locally
Pulling from registry…
Unable to find application "unknown": failed to resolve bundle manifest "docker.io/library/unknown:latest": pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed

- A picture of a cute animal (not mandatory but encouraged) image

codecov[bot] commented 4 years ago

Codecov Report

Merging #687 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #687   +/-   ##
=======================================
  Coverage   71.82%   71.82%           
=======================================
  Files          56       56           
  Lines        2889     2889           
=======================================
  Hits         2075     2075           
  Misses        550      550           
  Partials      264      264

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8fa4476...f4dfec5. Read the comment docs.