docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 176 forks source link

Adjust the "docker app build" UX #691

Closed ndeloof closed 4 years ago

ndeloof commented 4 years ago

- What I did Amended the docker app build user experience: tag is optional (set by --tag option) a context path is required (aligned with docker build)

- How I did it service image get tagged, based on metadata or --tag option

- How to verify it docker app build --t foo:1 . will tag built services images as foo:1-service and invocation image as foo-1-installer

- Description for the changelog Service images get tagged during build to match --tag option or metadata

- A picture of a cute animal (not mandatory but encouraged) image

codecov[bot] commented 4 years ago

Codecov Report

Merging #691 into master will decrease coverage by 0.09%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #691     +/-   ##
=========================================
- Coverage   72.51%   72.41%   -0.1%     
=========================================
  Files          56       56             
  Lines        3002     3031     +29     
=========================================
+ Hits         2177     2195     +18     
- Misses        552      559      +7     
- Partials      273      277      +4
Impacted Files Coverage Δ
internal/commands/build/compose.go 80.43% <0%> (-12.02%) :arrow_down:
internal/commands/build/build.go 71.35% <0%> (-5.01%) :arrow_down:
internal/commands/update.go
internal/commands/upgrade.go 58.18% <0%> (ø)
internal/store/digest.go 90.47% <0%> (+7.14%) :arrow_up:
internal/commands/image/list.go 89% <0%> (+7.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f1a594...52b815d. Read the comment docs.