Closed glours closed 4 years ago
Merging #697 into master will decrease coverage by
0.22%
. The diff coverage is72.97%
.
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
- Coverage 72.08% 71.85% -0.23%
==========================================
Files 62 56 -6
Lines 3496 2931 -565
==========================================
- Hits 2520 2106 -414
+ Misses 653 552 -101
+ Partials 323 273 -50
Impacted Files | Coverage Δ | |
---|---|---|
internal/commands/build/compose.go | 82.85% <100%> (ø) |
:arrow_up: |
internal/commands/build/build.go | 61.07% <63.63%> (+0.2%) |
:arrow_up: |
internal/commands/build/types.go | 69.23% <76%> (+0.48%) |
:arrow_up: |
internal/commands/run.go | 65.71% <0%> (-10.38%) |
:arrow_down: |
internal/store/digest.go | 83.33% <0%> (-8.34%) |
:arrow_down: |
internal/commands/pull.go | 69.23% <0%> (-7.92%) |
:arrow_down: |
internal/commands/image/list.go | 81.81% <0%> (-7.19%) |
:arrow_down: |
internal/commands/update.go | 58.18% <0%> (-4.98%) |
:arrow_down: |
internal/commands/push.go | 45.22% <0%> (-3.83%) |
:arrow_down: |
internal/commands/root.go | 78.88% <0%> (-3.57%) |
:arrow_down: |
... and 11 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c622dcf...1ee6dd3. Read the comment docs.
@glours can you rebase? 🦁
Is it possible to add some information to the PR description?
@eunomie PR description updated, sorry for that
- What I did Pass
--build-arg
parameter to buildx to build service images- How I did it Add a
--build-arg
flag Check a build arg isn't defined twice Replace build arg defined in compose file & pass the list of args to buildx for generating service images- How to verify it
Test main workflow run
docker --debug app build e2e/testdata/build/ --build-arg REPLACE_BY_BUILD_ARG=plop
check you see the following trace in the debug output in theworker
section of thecom.docker.app.invocation-image
Find the
worker
image sha256 & then do adocker image inspect
with the given sha & make sure to haveTest error message
run
docker app build e2e/testdata/build/single.dockerapp --build-arg REPLACE_BY_BUILD_ARG=plop --build-arg REPLACE_BY_BUILD_ARG
and check you have the following error message'--build-arg REPLACE_BY_BUILD_ARG' is defined twice
- A picture of a cute animal (not mandatory but encouraged)![image](https://user-images.githubusercontent.com/705411/66934392-b069bd80-f03a-11e9-9176-4eae93be561d.png)