docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 176 forks source link

If no image tag set use image content-digest #703

Closed ndeloof closed 4 years ago

ndeloof commented 4 years ago

- What I did Support running a docker app build without service image tags https://docker.atlassian.net/browse/APP-271

- How I did it Use the content-digest of the image, which docker engine can resolve if already pulled

- How to verify it Use a compose file without explicit image tag docker app build && docker app run

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

image

codecov[bot] commented 4 years ago

Codecov Report

Merging #703 into master will decrease coverage by 0.82%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
- Coverage   72.11%   71.29%   -0.83%     
==========================================
  Files          59       59              
  Lines        3016     2947      -69     
==========================================
- Hits         2175     2101      -74     
- Misses        560      570      +10     
+ Partials      281      276       -5
Impacted Files Coverage Δ
render/render.go 79.34% <0%> (-1.77%) :arrow_down:
internal/cnab/cnab.go 64.61% <0%> (-16.58%) :arrow_down:
internal/commands/run.go 65.71% <0%> (-7.62%) :arrow_down:
types/parameters/parameters.go 92.06% <0%> (-4.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0c6905a...65875cf. Read the comment docs.