docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 176 forks source link

Validate parameters against the actual compose file #710

Closed ndeloof closed 4 years ago

ndeloof commented 4 years ago

- What I did add a validation step to ensure parameters are actually used by compose file

- How I did it Reused ExtractVariables from init and compare with parameters

- How to verify it validate a dockerapp with unecessart parameters

- Description for the changelog docker app validate do check parameters are in actual use by compose file

- A picture of a cute animal (not mandatory but encouraged) image

codecov[bot] commented 4 years ago

Codecov Report

Merging #710 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #710   +/-   ##
======================================
  Coverage    71.2%   71.2%           
======================================
  Files          59      59           
  Lines        3011    3011           
======================================
  Hits         2144    2144           
  Misses        583     583           
  Partials      284     284

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e215e7...5fe2739. Read the comment docs.