Open EmbeddedAndroid opened 4 years ago
@EmbeddedAndroid thanks for reporting this.
Docker App is not enforcing this but docker is, a docker image name cannot have uppercase letters.
When you run render
we create the invocation image and run render inside it. We take the name of the image from the metadata (Ubuntu
in your case), hence the error.
We'll take a look at this and figure out what we want to do in this case, the most straightforward thing to do would be to take the name of the application and make it compatible with docker.
@rumpl Thanks for the explanation, now it makes sense to me.
I will document this behavior for our users so they don't stumble over this for now. Thanks for the great work on docker-apps!
P.S. We've added support to deliver docker-apps via theupdateframework on embedded devices. If you curious, we did some live demos on youtube here: https://www.youtube.com/watch?v=2k73RVpbjjw
Awesome, thanks for sharing this! Would you be interested in a ~1h session with us so that we can show you what's coming in the future? Would love to have some feedback too.
Awesome, thanks for sharing this! Would you be interested in a ~1h session with us so that we can show you what's coming in the future? Would love to have some feedback too.
No problem at all!
I would be very interested in having a session, would i be able to invite a few engineers my from team as well? Drop me an email at tyler@foundries.io and we can go from there!
Description
In the CNAB Identifying Metadata section it states that
name MUST contain only characters from the Unicode graphic characters.
andThe Unicode graphic character set allowed for name includes letters, numbers, punctuation, symbols, and spaces; it does not include newlines or tabs.
However, I observed that docker-app is enforcing a requirement for the CNAB bundle
name
to be lowercase.Steps to reproduce the issue:
Using the following docker-app definition:
Run
docker-app render
on the above file.Describe the results you received:
When I attempted to render the above definition, I received this error:
Error: image name "Ubuntu:0.1.0-invoc" is invalid, please check name and version fields: invalid reference format: repository name must be lowercase
Describe the results you expected:
docker-app would render a docker-compose file.
Additional information you deem important (e.g. issue happens only occasionally):
Perhaps there is a good reason docker-app enforces this rule, but I'd like to understand why (so I can document it).
Output of
docker version
:Output of
docker app version
:Output of
docker info
: