chris-crone commented 4 years ago

- What I did Leveraged docker build --output to get artefacts from images. This means that we can avoid doing docker build && docker container create && docker cp && docker rm.

- How I did it

- How to verify it Existing tests should all pass.

- Description for the changelog N/A

- A picture of a cute animal (not mandatory but encouraged)

silvin-lubecki commented 4 years ago

chmod: cannot access 'bin/docker-linux': No such file or directory
docker.Makefile:46: recipe for target 'cli-cross' failed
make: *** [cli-cross] Error 1

chris-crone commented 4 years ago

I think this is because we don't use BuildKit on the CI

codecov[bot] commented 4 years ago

Codecov Report

Merging #712 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #712   +/-   ##
======================================
  Coverage    71.1%   71.1%           
======================================
  Files          59      59           
  Lines        2997    2997           
======================================
  Hits         2131    2131           
  Misses        582     582           
  Partials      284     284

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d08d65...9c1bd62. Read the comment docs.

docker / app

Use docker build output for binaries #712

Codecov Report