search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 176 forks source link

Use app naming rules in error and progress messages #713

Closed carolinebriaud closed 4 years ago

carolinebriaud commented 4 years ago

Signed-off-by: Caroline Briaud caroline.briaud@docker.com

- What I did Use App naming rules for error and progress messages

- How to verify it Go through error messages and progress messages

- A picture of a cute animal (not mandatory but encouraged) IMG_7603

silvin-lubecki commented 4 years ago 
=== Failed
=== FAIL: e2e TestPushPullInstall (16.76s)
    pushpull_test.go:185: assertion failed: 
        Command:  docker app run unknown
        ExitCode: 1
        Error:    exit status 1
        Stdout:   Pulling from registry...
        Stderr:   Unable to find application image "unknown:latest" locally
        Unable to find App "unknown": failed to resolve bundle manifest "docker.io/library/unknown:latest": pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed
        Failures:
        Expected stderr to contain "Unable to find application image \"unknown:latest\" locally\nUnable to find application \"unknown\": failed to resolve bundle manifest \"docker.io/library/unknown:latest\": pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed"
codecov[bot] commented 4 years ago

Codecov Report

Merging #713 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #713   +/-   ##
=======================================
  Coverage   71.58%   71.58%           
=======================================
  Files          59       59           
  Lines        3051     3051           
=======================================
  Hits         2184     2184           
  Misses        585      585           
  Partials      282      282

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e215e7...0abe6b4. Read the comment docs.