Closed eunomie closed 4 years ago
Merging #722 into master will decrease coverage by
1.48%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #722 +/- ##
==========================================
- Coverage 72.45% 70.96% -1.49%
==========================================
Files 59 59
Lines 3438 3031 -407
==========================================
- Hits 2491 2151 -340
+ Misses 612 589 -23
+ Partials 335 291 -44
Impacted Files | Coverage Δ | |
---|---|---|
internal/commands/run.go | 60.22% <0%> (-9.86%) |
:arrow_down: |
internal/commands/remove.go | 52% <0%> (-8.57%) |
:arrow_down: |
internal/store/bundle.go | 68.93% <0%> (-7.75%) |
:arrow_down: |
internal/commands/update.go | 58.18% <0%> (-7.21%) |
:arrow_down: |
internal/cnab/cnab.go | 63.33% <0%> (-6.24%) |
:arrow_down: |
internal/commands/image/list.go | 83.33% <0%> (-5.82%) |
:arrow_down: |
types/parameters/parameters.go | 92.06% <0%> (-4.77%) |
:arrow_down: |
internal/commands/push.go | 45.22% <0%> (-2.57%) |
:arrow_down: |
internal/commands/image/tag.go | 88.88% <0%> (-1.31%) |
:arrow_down: |
internal/store/digest.go | 86.36% <0%> (-0.82%) |
:arrow_down: |
... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6267dc4...03792ed. Read the comment docs.
Well, encouraged is not a blocker...
Yep, blocker is maybe too strong.
And it's explicit that it's not mandatory.
Yes, but it's explicit that is encouraged and I don't think it's necessary.
Could you add some tests? The coverage seems to go down with this PR
Because it's only folklore and should not be a blocker.
- What I did
Just removed the
but encouraged
about picture of animal in PR template- How I did it
- How to verify it
- Description for the changelog