docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Move render command under image command #726

Closed jcsirot closed 4 years ago

jcsirot commented 4 years ago

- What I did Remove the render command and move it as new image subcommand.

- How I did it Move render.go into image package. Bundle parameters merging algorithm is invoked from some root commands and image render command. Therefore the bundle parameters merging had to be move to a dedicated package in order to avoid go package cycles.

- How to verify it

- A picture of a cute animal (not mandatory)

image

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6f5737a). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #726   +/-   ##
=========================================
  Coverage          ?   71.42%           
=========================================
  Files             ?       59           
  Lines             ?     3178           
  Branches          ?        0           
=========================================
  Hits              ?     2270           
  Misses            ?      602           
  Partials          ?      306
Impacted Files Coverage Δ
internal/commands/root.go 74.72% <ø> (ø)
internal/commands/image/render.go 72.41% <100%> (ø)
internal/bundle/parameters.go 86.51% <100%> (ø)
internal/commands/update.go 58.18% <100%> (ø)
internal/commands/run.go 61.11% <100%> (ø)
internal/commands/image/command.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f5737a...3c05dee. Read the comment docs.