aiordache commented 4 years ago

- What I did Updated the e2e tests that were using the --folder flag

- How to verify it The e2e TestRender/envvariables test should pass now.

- A picture of a cute animal (not mandatory)

Signed-off-by: Anca Iordache anca.iordache@docker.com

GordonTheTurtle commented 4 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "app-304_correct_app_build_help" git@github.com:aiordache/app.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6f5737a). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #727   +/-   ##
=========================================
  Coverage          ?   71.43%           
=========================================
  Files             ?       59           
  Lines             ?     3175           
  Branches          ?        0           
=========================================
  Hits              ?     2268           
  Misses            ?      601           
  Partials          ?      306

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f5737a...7af854e. Read the comment docs.

docker / app

APP-304 Update e2e tests using --folder flag #727

Codecov Report