search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 176 forks source link

Make flag cnab-bunle-json experimental #731

Closed rumpl closed 4 years ago

rumpl commented 4 years ago

- What I did

Once app is GA and no longer hidden experimental we will want to hide the cnab-bundle-json flag if the user didn't activate experimental features. docker/cli was updated to latest that had the fix for cli plugins to be able to get the client configuration (https://github.com/docker/cli/pull/2095)

- How to verify it

Can't really verify it for now, nor can I write a test for this...

- A picture of a cute animal (not mandatory) image

rumpl commented 4 years ago

It's draft because the test fails and I'm waiting for #721 to be merged

codecov[bot] commented 4 years ago

Codecov Report

Merging #731 into master will decrease coverage by 0.43%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
- Coverage   69.72%   69.29%   -0.44%     
==========================================
  Files          64       63       -1     
  Lines        3495     3397      -98     
==========================================
- Hits         2437     2354      -83     
+ Misses        738      733       -5     
+ Partials      320      310      -10
Impacted Files Coverage Δ
internal/commands/run.go 61.95% <100%> (+0.41%) :arrow_up:
internal/commands/image/list.go 83.67% <0%> (-4%) :arrow_down:
internal/packager/custom.go
internal/packager/cnab.go 97.94% <0%> (+0.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aeb12c0...9035402. Read the comment docs.