Closed rumpl closed 4 years ago
Merging #732 into master will decrease coverage by
0.07%
. The diff coverage is50%
.
@@ Coverage Diff @@
## master #732 +/- ##
==========================================
- Coverage 70.1% 70.02% -0.08%
==========================================
Files 62 62
Lines 3318 3213 -105
==========================================
- Hits 2326 2250 -76
+ Misses 682 660 -22
+ Partials 310 303 -7
Impacted Files | Coverage Δ | |
---|---|---|
internal/commands/push.go | 33.08% <50%> (-7.71%) |
:arrow_down: |
internal/cnab/cnab.go | 32.3% <0%> (-18.47%) |
:arrow_down: |
internal/packager/init.go | 61.68% <0%> (-1.59%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c7927e1...1fd4785. Read the comment docs.
- What I did
cnab.ResolveBundle
would try the local store first and pull if the app is not found. This is not what we want when we push. We only want to push local applications.- A picture of a cute animal (not mandatory)![image](https://user-images.githubusercontent.com/99933/68482037-f03a5400-0238-11ea-910a-11aa7b323484.png)