docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 176 forks source link

Check compose file don't use relative paths for bind mount #742

Closed ndeloof closed 4 years ago

ndeloof commented 4 years ago

- What I did Reject compose file to use a relative path for bind mount https://docker.atlassian.net/browse/APP-275

- How I did it

- How to verify it

- Description for the changelog Docker app do reject compose file relying on a relative volume path

- A picture of a cute animal (not mandatory) image

codecov[bot] commented 4 years ago

Codecov Report

Merging #742 into master will increase coverage by <.01%. The diff coverage is 71.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   68.97%   68.98%   +<.01%     
==========================================
  Files          64       63       -1     
  Lines        3439     3440       +1     
==========================================
+ Hits         2372     2373       +1     
  Misses        749      749              
  Partials      318      318
Impacted Files Coverage Δ
internal/commands/build/build.go 60.4% <66.66%> (ø) :arrow_up:
internal/packager/init.go 64.64% <70.58%> (+1.37%) :arrow_up:
internal/commands/build/compose.go 78.57% <73.33%> (-5.22%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b339e0b...0372f49. Read the comment docs.