Closed ndeloof closed 4 years ago
Merging #742 into master will increase coverage by
<.01%
. The diff coverage is71.64%
.
@@ Coverage Diff @@
## master #742 +/- ##
==========================================
+ Coverage 68.97% 68.98% +<.01%
==========================================
Files 64 63 -1
Lines 3439 3440 +1
==========================================
+ Hits 2372 2373 +1
Misses 749 749
Partials 318 318
Impacted Files | Coverage Δ | |
---|---|---|
internal/commands/build/build.go | 60.4% <66.66%> (ø) |
:arrow_up: |
internal/packager/init.go | 64.64% <70.58%> (+1.37%) |
:arrow_up: |
internal/commands/build/compose.go | 78.57% <73.33%> (-5.22%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b339e0b...0372f49. Read the comment docs.
- What I did Reject compose file to use a relative path for bind mount https://docker.atlassian.net/browse/APP-275
- How I did it
- How to verify it
docker app init
docker app build
- Description for the changelog Docker app do reject compose file relying on a relative volume path
- A picture of a cute animal (not mandatory)![image](https://user-images.githubusercontent.com/132757/68763484-da51d800-0618-11ea-93bf-6741784334ed.png)