docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 176 forks source link

Remove extra flags on docker app inspect command #751

Closed silvin-lubecki closed 4 years ago

silvin-lubecki commented 4 years ago

- What I did orchestrator and namespace flags are not needed, as they are parameters stored in the claim so we can retrieve them. The user shouldn't be allowed to override them.

Also removed default orchestrator code for inspect, as orchestrator is not mandatory for every bundles (some bundles may just run on a single engine).

- Description for the changelog

- A picture of a cute animal (not mandatory) image

codecov[bot] commented 4 years ago

Codecov Report

Merging #751 into master will increase coverage by 0.65%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
+ Coverage   68.59%   69.25%   +0.65%     
==========================================
  Files          63       63              
  Lines        3477     3428      -49     
==========================================
- Hits         2385     2374      -11     
+ Misses        775      738      -37     
+ Partials      317      316       -1
Impacted Files Coverage Δ
internal/commands/inspect.go 17.46% <0%> (+1.21%) :arrow_up:
internal/inspect/inspect.go 89.2% <85.71%> (+0.5%) :arrow_up:
internal/commands/push.go 33.58% <0%> (+0.87%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0249717...fb411ac. Read the comment docs.