docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 176 forks source link

Image inspect non-app CNABs #753

Closed zappy-shu closed 4 years ago

zappy-shu commented 4 years ago

- What I did

Allow image inspect of CNABs not created with docker app. The command will output basic information that is read from the bundle.json file including:

Metadata fields are now printed in PascalCase to match the other fields

- How I did it

The image inspect command first checks if the invocation image supports the custom com.docker.app.inspect command. If yes then this is called with the format as before. If not then it's not a Docker App bundle and the bundle file is parsed for the relevant information which is then printed using the same formatters as the Docker App inspect function.

- How to verify it

Manually create a CNAB, push it to hub with cnab-to-oci, and pull it with docker app. Use docker app image inspect <cnab-id> and confirm the output contains the metadata, services, and parameters.

You can also use docker app image inspect <cnab-id> --pretty to get a table view but 2 fields are removed (REPLICAS and PORTS)

- Description for the changelog

Allow docker app image inspect of CNAB bundles created without Docker App

- A picture of a cute animal (not mandatory)

cat-2019-11-19

codecov[bot] commented 4 years ago

Codecov Report

Merging #753 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #753   +/-   ##
=======================================
  Coverage   69.94%   69.94%           
=======================================
  Files          63       63           
  Lines        3540     3540           
=======================================
  Hits         2476     2476           
  Misses        744      744           
  Partials      320      320

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 355ab4f...8908b28. Read the comment docs.