aiordache commented 4 years ago

APP-257

- What I did Check mandatory fields in the CNAB bundle for v1.

Added E2E test for running an app generated with an old docker app version.

- Description for the changelog E2E test for backwards compatibility

- A picture of a cute animal (not mandatory)

GordonTheTurtle commented 4 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "app-257_cnab_api_tests" git@github.com:aiordache/app.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354111120
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

codecov[bot] commented 4 years ago

Codecov Report

Merging #755 into master will increase coverage by 0.08%. The diff coverage is 74.35%.

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   70.17%   70.26%   +0.08%     
==========================================
  Files          64       64              
  Lines        3568     3598      +30     
==========================================
+ Hits         2504     2528      +24     
- Misses        732      735       +3     
- Partials      332      335       +3

Impacted Files	Coverage Δ
internal/commands/image/rm.go	`62.5% <71.42%> (+3.87%)`	:arrow_up:
internal/store/bundle.go	`76.57% <75%> (+0.16%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3a9aed...ec4a452. Read the comment docs.

docker / app

[APP-257] Add integration tests to check CNAB bundle API #755

Codecov Report