docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 176 forks source link

Add services column to docker app ls command #757

Closed silvin-lubecki closed 4 years ago

silvin-lubecki commented 4 years ago

- What I did The current docker app ls command relies only on parsing claims in the local claim store and its last action, so it is totally uncorrelated with the current app status.

- How I did it

- How to verify it

 $ docker app ls           
INSTALLATION          APPLICATION   SERVICES LAST ACTION RESULT  CREATED     MODIFIED    REFERENCE
socks                 socks (0.1)   13/13    install     success 4 hours ago 4 hours ago docker.io/library/sockshop:latest
sweet_cartwright      coins (0.1.0) N/A      install     failure 4 days ago  4 days ago  79390aac20c7945c22f18d3bc2a029a9a2aaf07aca6bef458ec18014085b010a
compassionate_mcnulty coins (0.1.0) N/A      install     success 11 days ago 11 days ago 79390aac20c7945c22f18d3bc2a029a9a2aaf07aca6bef458ec18014085b010a

$ docker ps               
CONTAINER ID        IMAGE                                COMMAND                  CREATED              STATUS              PORTS                                NAMES
6b93b1f4d147        weaveworksdemos/user-db:0.4.0        "/entrypoint.sh mong…"   54 seconds ago       Up 40 seconds       27017/tcp                            socks_user-db.1.ru12155gazmubn4ptz18ujelg
123a1d4a9737        weaveworksdemos/load-test:0.1.1      "/usr/local/bin/runL…"   About a minute ago   Up About a minute   8089/tcp                             socks_user-sim.1.f42swbjvlrbo8wp5q974nev9g
8f5f61e99639        weaveworksdemos/payment:0.4.3        "/app -port=80"          4 hours ago          Up 4 hours          80/tcp                               socks_payment.1.lsc40gglfm5qejdoebzyfsf16

$ docker kill 6b93b1f4d147
6b93b1f4d147

$ docker app ls           
INSTALLATION          APPLICATION   SERVICES LAST ACTION RESULT  CREATED     MODIFIED    REFERENCE
socks                 socks (0.1)   12/13    install     success 4 hours ago 4 hours ago docker.io/library/sockshop:latest
sweet_cartwright      coins (0.1.0) N/A      install     failure 4 days ago  4 days ago  79390aac20c7945c22f18d3bc2a029a9a2aaf07aca6bef458ec18014085b010a
compassionate_mcnulty coins (0.1.0) N/A      install     success 11 days ago 11 days ago 79390aac20c7945c22f18d3bc2a029a9a2aaf07aca6bef458ec18014085b010a

- Description for the changelog

- A picture of a cute animal (not mandatory) image

codecov[bot] commented 4 years ago

Codecov Report

Merging #757 into master will decrease coverage by 0.49%. The diff coverage is 78.46%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #757     +/-   ##
=========================================
- Coverage   70.07%   69.58%   -0.5%     
=========================================
  Files          64       64             
  Lines        3519     3567     +48     
=========================================
+ Hits         2466     2482     +16     
- Misses        727      757     +30     
- Partials      326      328      +2
Impacted Files Coverage Δ
internal/cnab/driver.go 77.77% <100%> (ø) :arrow_up:
internal/commands/run.go 63.73% <100%> (-0.4%) :arrow_down:
internal/commands/image/inspect.go 65.3% <100%> (-0.7%) :arrow_down:
internal/commands/image/render.go 69.49% <100%> (-0.51%) :arrow_down:
internal/commands/update.go 58.92% <100%> (-0.73%) :arrow_down:
internal/commands/remove.go 52.94% <100%> (-0.91%) :arrow_down:
internal/commands/image/command.go 100% <100%> (ø) :arrow_up:
internal/commands/inspect.go 21.66% <25%> (-29.16%) :arrow_down:
internal/commands/list.go 70.63% <70.88%> (-0.99%) :arrow_down:
internal/commands/validate.go 75% <75%> (ø) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b621499...f84667a. Read the comment docs.

silvin-lubecki commented 4 years ago

PTAL