Closed greatonerahul closed 4 years ago
Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:greatonerahul/app.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
Merging #763 into master will decrease coverage by
1.05%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #763 +/- ##
=========================================
- Coverage 70.56% 69.5% -1.06%
=========================================
Files 67 64 -3
Lines 3717 3519 -198
=========================================
- Hits 2623 2446 -177
+ Misses 766 753 -13
+ Partials 328 320 -8
Impacted Files | Coverage Δ | |
---|---|---|
internal/packager/init.go | 64.64% <0%> (-8.61%) |
:arrow_down: |
internal/packager/extract.go | 23.8% <0%> (-8.4%) |
:arrow_down: |
internal/commands/build/compose.go | 78.57% <0%> (-8.1%) |
:arrow_down: |
internal/validator/rules/relativepath.go | ||
internal/validator/rules/externalsecrets.go | ||
internal/validator/validator.go |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f38c337...e71bace. Read the comment docs.
@greatonerahul Is this a real Pull Request? If so can you explain a bit more what you are trying to achieve? Unless this PR will be closed.
test file docker added
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory)