search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 176 forks source link

Create a context for the progress printer #764

Closed rumpl closed 4 years ago

rumpl commented 4 years ago

We call cancel on the context once we finished so that it will stop printing stuff. This could fix APP-349 and could fix the errors with status code 141 that we see on our CI.

codecov[bot] commented 4 years ago

Codecov Report

Merging #764 into master will decrease coverage by 1.75%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
- Coverage   71.27%   69.52%   -1.76%     
==========================================
  Files          67       64       -3     
  Lines        3837     3521     -316     
==========================================
- Hits         2735     2448     -287     
+ Misses        768      753      -15     
+ Partials      334      320      -14
Impacted Files Coverage Δ
internal/commands/build/build.go 60.8% <100%> (+0.39%) :arrow_up:
internal/commands/image/rm.go 58.62% <0%> (-11.15%) :arrow_down:
internal/packager/init.go 64.64% <0%> (-8.61%) :arrow_down:
internal/packager/extract.go 23.8% <0%> (-8.4%) :arrow_down:
internal/commands/build/compose.go 78.57% <0%> (-8.1%) :arrow_down:
internal/store/bundle.go 76.41% <0%> (-5.99%) :arrow_down:
internal/validator/rules/relativepath.go
internal/validator/rules/externalsecrets.go
internal/validator/validator.go

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f38c337...cebcef5. Read the comment docs.