Closed silvin-lubecki closed 4 years ago
Merging #769 into master will decrease coverage by
1.56%
. The diff coverage is55.55%
.
@@ Coverage Diff @@
## master #769 +/- ##
==========================================
- Coverage 72.09% 70.52% -1.57%
==========================================
Files 67 67
Lines 3838 3729 -109
==========================================
- Hits 2767 2630 -137
- Misses 739 756 +17
- Partials 332 343 +11
Impacted Files | Coverage Δ | |
---|---|---|
internal/commands/pull.go | 64.28% <0%> (-4.95%) |
:arrow_down: |
internal/commands/run.go | 62.36% <0%> (-1.38%) |
:arrow_down: |
internal/packager/cnab.go | 96.98% <100%> (ø) |
:arrow_up: |
internal/commands/image/inspect.go | 66.66% <33.33%> (-2.73%) |
:arrow_down: |
internal/commands/update.go | 56.89% <33.33%> (-2.04%) |
:arrow_down: |
internal/commands/inspect.go | 48.38% <33.33%> (-1.62%) |
:arrow_down: |
internal/commands/remove.go | 50.94% <33.33%> (-2%) |
:arrow_down: |
internal/commands/image/render.go | 67.85% <52.38%> (-1.64%) |
:arrow_down: |
internal/packager/custom.go | 73.33% <87.5%> (+12.04%) |
:arrow_up: |
internal/commands/build/build.go | 60% <0%> (-20.42%) |
:arrow_down: |
... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e18898a...12e6785. Read the comment docs.
- What I did I now check current app version vs bundle app version if any and print a warning if it differs on the following commands:
- How I did it I stored a new field "app-version" in the bundle's custom payload section, so I can compare built app image with the current app binary version.
- How to verify it
~/.docker/app/bundles/..../bundle.json
), find where the custom payload is and change theapp-version
field- Description for the changelog
- A picture of a cute animal (not mandatory)![image](https://user-images.githubusercontent.com/31478878/69724849-0abb6b00-111d-11ea-9283-07683d152bc5.png)