search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Allow rm of multiple apps in one command #775

Closed zappy-shu closed 4 years ago

zappy-shu commented 4 years ago

- What I did

Adds ability to remove multiple running apps with a single command. E.g.: docker app rm app1 app2

Attempts to remove all listed apps before returning any errors same as with docker app image rm.

- How I did it

Changed the ExactArgs to RequiredMinArgs and loop through the args, appending any errors which are all returned at the end if any exist.

- How to verify it

docker app run 2 apps with names app1 and app2 then docker app rm app1 app2. The output should show each app being removed

- Description for the changelog

Allow removing of multiple Apps in one command using space delimited App names. E.g. docker app rm my-app-1 my-app-2

- A picture of a cute animal (not mandatory)

hippo-2019-12-02

codecov[bot] commented 4 years ago

Codecov Report

Merging #775 into master will decrease coverage by 0.02%. The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
- Coverage   70.44%   70.41%   -0.03%     
==========================================
  Files          67       67              
  Lines        3729     3732       +3     
==========================================
+ Hits         2627     2628       +1     
- Misses        758      759       +1     
- Partials      344      345       +1
Impacted Files Coverage Δ
internal/commands/remove.go 50% <60%> (-0.95%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d119541...518754b. Read the comment docs.