docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Remove CREATED from bundle.json #778

Closed zappy-shu closed 4 years ago

zappy-shu commented 4 years ago

- What I did

Removes the created date from the bundle.json and the image ls output

This has been done to make builds more reproducable as the current solution means the App Image ID will change on each build

We will look at re-adding the created date once the underlying bundle store has been updated.

- How to verify it

Build a Docker App and:

- Description for the changelog

Removes custom created date from Docker App bundle.json so as to make builds more repeatable.

- A picture of a cute animal (not mandatory)

animalissue2-1-43f2a278bdb53e2e

codecov[bot] commented 4 years ago

Codecov Report

Merging #778 into master will decrease coverage by 1.48%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
- Coverage   71.82%   70.33%   -1.49%     
==========================================
  Files          67       67              
  Lines        3858     3712     -146     
==========================================
- Hits         2771     2611     -160     
- Misses        739      757      +18     
+ Partials      348      344       -4
Impacted Files Coverage Δ
internal/commands/image/list.go 81.53% <ø> (-3.08%) :arrow_down:
internal/packager/custom.go 72.09% <100%> (-1.25%) :arrow_down:
internal/commands/image/formatter.go 85.96% <100%> (-1.14%) :arrow_down:
internal/commands/build/build.go 60% <0%> (-19.46%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d198096...79189e7. Read the comment docs.