docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 176 forks source link

Add "--service-images" to pull command #791

Open doanac opened 4 years ago

doanac commented 4 years ago

This allows users in a single node configuration to optionally pull down the service images defined in an app bundle with:

docker app pull --service-images [your app]

Fixes: fixes #789

Signed-off-by: Andy Doan andy@foundries.io

silvin-lubecki commented 4 years ago

Thank you @doanac for this PR! By the way the linter is complaining 😅

internal/commands/pull.go:8: File is not `goimports`-ed (goimports)
"github.com/docker/docker/api/types"
codecov[bot] commented 4 years ago

Codecov Report

Merging #791 into master will decrease coverage by 0.05%. The diff coverage is 65.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
- Coverage   70.03%   69.97%   -0.06%     
==========================================
  Files          67       67              
  Lines        3684     3710      +26     
==========================================
+ Hits         2580     2596      +16     
- Misses        759      764       +5     
- Partials      345      350       +5
Impacted Files Coverage Δ
internal/commands/pull.go 62.96% <65.51%> (-1.33%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d698be...42f1daa. Read the comment docs.