search

docker / awesome-compose

Awesome Docker Compose samples
https://docs.docker.com/compose/
Creative Commons Zero v1.0 Universal
33.44k stars 6.45k forks source link

Proposal: Ruby on Rails Sample application #287

Open kochalex opened 1 year ago

kochalex commented 1 year ago

Hi, I was checking out the new docker dev environments feature, saw there is not a rails application, and that the existing pull request is stalled.

I have a fairly simple one ready to submit at https://github.com/kochalex/awesome-compose/tree/sample-rails

nicksieger commented 1 year ago

Hey @kochalex, thanks for submitting this! It looks pretty good to me overall. It looks like you may have copied the readme and some boilerplate from another sample, as the readme mentions a db/password.txt file. Do you want to wire up that file as a secret and mount it into the project or just change the readme to remove that? Feel free to submit your sample as a PR, I'd personally like to see a Rails sample app.

kochalex commented 1 year ago

Ah yes, I did copy the readme from the react-express-mysql example, I'll fix, double-check the readme, and submit.