Closed millotp closed 6 days ago
Actual behaviour
Yes we should keep default retention days set in repository settings. I think I will just remove the override here and allow customization with a new env var. Pretty much like https://github.com/actions/upload-artifact/ does.
@millotp Should be fixed with https://github.com/docker/build-push-action/pull/1153
You can try with:
Default from repo settings:
uses: crazy-max/docker-build-push-action@export-retention
with:
file: build/docker/Dockerfile
context: .
push: false
Or custom value:
uses: crazy-max/docker-build-push-action@export-retention
with:
file: build/docker/Dockerfile
context: .
push: false
env:
DOCKER_BUILD_EXPORT_RETENTION_DAYS: 2
Thanks for the speedy fix !
Contributing guidelines
I've found a bug, and:
Description
Hello,
With the new feature in 6.0.0 to upload build artifacts, the retention time is set to
90 days
(source) and is not configurable, which gives warning when the repository already has a default retention.I like the new feature and would like to keep it, would it be possible to make this configurable, or use the repo default value directly ?
Expected behaviour
No warnings displayed
Actual behaviour
Repository URL
No response
Workflow run URL
No response
YAML workflow
Workflow logs
No response
BuildKit logs
No response
Additional info
No response