docker / build-push-action

GitHub Action to build and push Docker images with Buildx
https://github.com/marketplace/actions/build-and-push-docker-images
Apache License 2.0
4.31k stars 553 forks source link

Support `annotations` option #958

Closed favonia closed 10 months ago

favonia commented 1 year ago

Description

(I am creating a new issue because the focus of the old issue #854 is unclear.)

I wish build-push-action can support annotations just like labels, once the new --annotation shortcut (https://github.com/docker/buildx/pull/2020) is officially available. Essentially, the script should append a new parameter --annotation "line" for each line in the value of annotations, just like how it appends a new --label "line" now for each line in the value of labels.

crazy-max commented 1 year ago

--annotation flag PR has just been merged on buildx repo https://github.com/docker/buildx/pull/2020 and will be available on next 0.12 release. We could then add a new input for this action as follow-up. (cc @jedevc)

jedevc commented 1 year ago

@crazy-max sgtm :tada: I think the release of v0.12 should be scheduled for fairly soon?

crazy-max commented 1 year ago

I think the release of v0.12 should be scheduled for fairly soon?

Yes maybe an RC next week :crossed_fingers: