search

docker / build-push-action

GitHub Action to build and push Docker images with Buildx
https://github.com/marketplace/actions/build-and-push-docker-images
Apache License 2.0
4.11k stars 527 forks source link

add annotations input #992

Closed crazy-max closed 7 months ago

crazy-max commented 8 months ago

follow-up https://github.com/docker/buildx/pull/2020 fixes https://github.com/docker/build-push-action/issues/958

favonia commented 8 months ago

Close #958. (Will my keyword works?)

EDIT: it doesn't seem to work... but anyway that might be the issue that should be closed along with this PR.

favonia commented 7 months ago

@crazy-max @tonistiigi Hi, as an outsider I feel the PR might not be ready for merging. It seems to have two outstanding issues: (1) the CI was testing "v0.12.0-rc1" not the latest version, which doesn't seem to be normal, and (2) it will silently ignore annotations when buildx is too old. Of course, we can fix these in another PR, but I found the merge a bit strange given these issues. I'll be happy to learn that I'm wrong. Anyway, thank you for moving forward on this issue quickly. 😀

crazy-max commented 7 months ago

(1) the CI was testing "v0.12.0-rc1" not the latest version,

Yes we are going to open a follow-up here to update to latest when Buildx 0.12.0 is GA this week. We have done this quite often when adding new inputs like build-contexts for 0.8.0.