We've now merged #1770 to add support for integration tests :tada: However, buildx has been around for several years before these tests, so we don't have anywhere near the amount of test coverage that we want. These tests are essential to track regressions, detect changes in behavior as we refactor and build new functionality, and add new modes and drivers.
In general, all new functionality should be added with tests wherever feasible, but we need a plan to work through the existing backlog of code with no tests. This issue is to track what broad groups of tests we need, and how far along we are. This list isn't currently complete -- but as a general rule of thumb, if we document the behavior on https://docs.docker.com, we should be testing it.
Ideally, each sub-point in the list would end up as a PR, though maybe it makes sense to group some of the smaller ones together, or split some of the larger ones up.
(note to maintainers, feel free to add anything that you think is missing :partying_face:)
The first type of tests that we need are for the top-level commands package - at the time of writing, these currently reside in the top-level tests package. These are designed to test each of the buildx subcommands, such as build, bake, inspect, etc.
Not sure quite what this would look like, but some sanity checks on stdout to ensure that progress is continually printed, the ticker keeps updating, any relevant log messages correctly appear, warnings are displayed at the end of build, etc.
[ ] Different values for the --invoke flag (debug-shell, on-error, shell commands)
[ ] Monitor mode commands (attach/list/help/etc)
[ ] Breakpoints, etc (when added)
[ ] Disk management utilities with buildx du / buildx prune
[x] Versioning with buildx version (#1985)
[x] Builder management with buildx create/buildx rm/buildx ls/buildx stop/buildx use
This is going to need a more manual driver creation process, that's less integrated into the sandbox probably.
The second type of tests that we need are for the top-level driver package. These drivers allow connecting to buildkit running in different configurations. Each driver supports lots of different types of options, and so we should have tests that test for configuring and setting up buildkit with these different options. Currently, we don't have any tests of this format.
We've now merged #1770 to add support for integration tests :tada: However, buildx has been around for several years before these tests, so we don't have anywhere near the amount of test coverage that we want. These tests are essential to track regressions, detect changes in behavior as we refactor and build new functionality, and add new modes and drivers.
In general, all new functionality should be added with tests wherever feasible, but we need a plan to work through the existing backlog of code with no tests. This issue is to track what broad groups of tests we need, and how far along we are. This list isn't currently complete -- but as a general rule of thumb, if we document the behavior on https://docs.docker.com, we should be testing it.
Ideally, each sub-point in the list would end up as a PR, though maybe it makes sense to group some of the smaller ones together, or split some of the larger ones up.
(note to maintainers, feel free to add anything that you think is missing :partying_face:)
The first type of tests that we need are for the top-level
commands
package - at the time of writing, these currently reside in the top-leveltests
package. These are designed to test each of the buildx subcommands, such asbuild
,bake
,inspect
, etc.The areas that we need coverage for:
buildx build
/buildx bake
--platform
) https://github.com/docker/buildx/pull/2620--cache-to
/--cache-from
/--no-cache
/--no-cache-filter
)--output
/--load
/--push
/--tag
) https://github.com/docker/buildx/pull/2302--build-arg
/--build-context
) https://github.com/docker/buildx/pull/2040--metadata-file
/--iidfile
)--print
) https://github.com/docker/buildx/pull/2423--secret
/--ssh
) https://github.com/docker/buildx/pull/2381--shm-size
) https://github.com/docker/buildx/pull/2279--ulimit
) https://github.com/docker/buildx/pull/2279--label
) https://github.com/docker/buildx/pull/2040--attest
/--provenance
/--sbom
) https://github.com/docker/buildx/pull/1988--progress
) https://github.com/docker/buildx/pull/1925BUILDX_EXPERIMENTAL
env var,--detach
flag) https://github.com/docker/buildx/pull/2376buildx imagetools
buildx imagetools inspect
) https://github.com/docker/buildx/pull/1965 https://github.com/docker/buildx/pull/1978buildx imagetools create
) https://github.com/docker/buildx/pull/2013--invoke
flag--invoke
flag (debug-shell
,on-error
, shell commands)attach
/list
/help
/etc)buildx du
/buildx prune
buildx version
(#1985)buildx create
/buildx rm
/buildx ls
/buildx stop
/buildx use
The second type of tests that we need are for the top-level
driver
package. These drivers allow connecting to buildkit running in different configurations. Each driver supports lots of different types of options, and so we should have tests that test for configuring and setting up buildkit with these different options. Currently, we don't have any tests of this format.The areas that we need coverage for:
docker
driverdocker-container
driver (see docs)kubernetes
driver (see docs)remote
driver (see docs)