search

docker / buildx

Docker CLI plugin for extended build capabilities with BuildKit
Apache License 2.0
3.33k stars 448 forks source link

Make multi-type annotation settings match docs #2522

Closed treuherz closed 1 week ago

treuherz commented 3 weeks ago

The Docker docs in multiple places describe passing an annotation at the command line like "index,manifest:com.example.name=my-cool-image", and say that this will result in the annotation being applied to both the index and the manifest. It doesn't seem like this was actually implemented, and instead it just results in an annotation key with "index,manifest:" at the beginning being applied to the manifest.

This change splits the part of the key before the colon by comma, and creates an annotation for each type/platform given, so the implementation should now match the docs.

treuherz commented 3 weeks ago

I get the same test failures locally with and without this change - I think these must be my setup rather than an actual problem. Hopefully the validation will be green but I'll mark as draft again if not.

treuherz commented 3 weeks ago

A dep changed from // indirect to direct - fixed, re-run vendor etc. Sorry about that