docker / cli

The Docker CLI
Apache License 2.0
4.88k stars 1.92k forks source link

Add plugin execution duration metric #5046

Open krissetto opened 5 months ago

krissetto commented 5 months ago

- What I did Added utils for instrumenting plugin commands, and instrumented them to record their execution time.

Note: This is disconnected from the specific metrics and traces created by the plugins themselves and it not meant to replace those, it only represents a measurement of the binary execution of the plugin from the CLI's point of view

- How I did it

- How to verify it

- Description for the changelog

Instrument plugin execution with otel meter

- A picture of a cute animal (not mandatory but encouraged)

pinta

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 2.73973% with 71 lines in your changes missing coverage. Please review.

Project coverage is 61.16%. Comparing base (28c5652) to head (a5644cd). Report is 456 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5046 +/- ## ========================================== - Coverage 61.33% 61.16% -0.18% ========================================== Files 298 298 Lines 20692 20750 +58 ========================================== Hits 12691 12691 - Misses 7100 7158 +58 Partials 901 901 ```
krissetto commented 4 months ago

The first commit is from here, for the sake of testing

vvoland commented 4 months ago

@krissetto Please rebase :)

krissetto commented 4 months ago

will fix this soon

thaJeztah commented 3 months ago

needs a rebase @krissetto 🙈