Closed vvoland closed 2 months ago
backport: https://github.com/docker/cli/pull/5038
follow-up to https://github.com/docker/cli/pull/5027
Commit 50117590567998307eba377295a1ec24e214ccc7 implemented a fix that caused the current environment to be discarded, using os.Environ(). On Windows, os.Environ() may produce an incorrect value for PWD, for which a new function was added in go1.19;
os.Environ()
PWD
Replace the use of os.Environ() with cmd.Environ() to address that.
cmd.Environ()
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.
0%
1 lines
Project coverage is 61.08%. Comparing base (1e6db5d) to head (1c6a8ec).
1e6db5d
1c6a8ec
backport: https://github.com/docker/cli/pull/5038
follow-up to https://github.com/docker/cli/pull/5027
Commit 50117590567998307eba377295a1ec24e214ccc7 implemented a fix that caused the current environment to be discarded, using
os.Environ()
. On Windows,os.Environ()
may produce an incorrect value forPWD
, for which a new function was added in go1.19;Replace the use of
os.Environ()
withcmd.Environ()
to address that.- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)